Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

admin access for certain tv clients #21282

Merged
merged 4 commits into from
Jul 28, 2022
Merged

admin access for certain tv clients #21282

merged 4 commits into from
Jul 28, 2022

Conversation

chrisdecenzo
Copy link
Contributor

@chrisdecenzo chrisdecenzo commented Jul 27, 2022 •
edited
Loading

Problem

  • Cannot run certain tv test cases from casting-app because casting apps are never given admin privileges

Change overview

  • Add feature to allow select vendor ids to get admin access to endpoints. This may be used for voice agent clients.

Testing

  • Tested using tv-app and tv-casting-app

@chrisdecenzo chrisdecenzo changed the title Draft: admin access for certain tv clients admin access for certain tv clients Jul 27, 2022
@woody-apple woody-apple enabled auto-merge (squash) July 27, 2022 23:31
@github-actions
Copy link

PR #21282: Size comparison from baf750a to f7b0f02

Increases (3 builds for mbed, nrfconnect)
platform target config section baf750a f7b0f02 change % change
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2449328 2450376 1048 0.0
.bss 214508 214516 8 0.0
.text 1411972 1413020 1048 0.1
nrfconnect all-clusters-app nrf52840dk_nrf52840 bss 143132 143140 8 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 bss 142368 142376 8 0.0
Decreases (2 builds for nrfconnect)
platform target config section baf750a f7b0f02 change % change
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1177131 1172683 -4448 -0.4
rodata 142660 141820 -840 -0.6
text 812408 808808 -3600 -0.4
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1157183 1152735 -4448 -0.4
rodata 134192 133352 -840 -0.6
text 801716 798120 -3596 -0.4
Full report (3 builds for mbed, nrfconnect)
platform target config section baf750a f7b0f02 change % change
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2449328 2450376 1048 0.0
.bss 214508 214516 8 0.0
.data 5872 5872 0 0.0
.text 1411972 1413020 1048 0.1
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1177131 1172683 -4448 -0.4
bss 143132 143140 8 0.0
rodata 142660 141820 -840 -0.6
text 812408 808808 -3600 -0.4
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1157183 1152735 -4448 -0.4
bss 142368 142376 8 0.0
rodata 134192 133352 -840 -0.6
text 801716 798120 -3596 -0.4

@github-actions
Copy link

github-actions bot commented Jul 28, 2022 •
edited
Loading

PR #21282: Size comparison from 1679342 to cb00b32

Increases (4 builds for cc13x2_26x2, esp32, mbed)
platform target config section 1679342 cb00b32 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 182980 182988 8 0.0
lock-ftd LP_CC2652R7 (read only) 671487 671495 8 0.0
.text 594744 594752 8 0.0
esp32 all-clusters-app c3devkit (read only) 1022520 1022524 4 0.0
.flash.text 1022520 1022524 4 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2450608 2450672 64 0.0
.text 1413252 1413316 64 0.0
Decreases (2 builds for cc13x2_26x2)
platform target config section 1679342 cb00b32 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 668363 668355 -8 -0.0
.text 579852 579844 -8 -0.0
lock-ftd LP_CC2652R7 (read/write) 170048 170040 -8 -0.0
Full report (12 builds for cc13x2_26x2, esp32, mbed, nrfconnect)
platform target config section 1679342 cb00b32 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 668363 668355 -8 -0.0
(read/write) 182980 182988 8 0.0
.bss 74236 74236 0 0.0
.data 3372 3372 0 0.0
.rodata 88195 88195 0 0.0
.text 579852 579844 -8 -0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 633939 633939 0 0.0
(read/write) 157820 157820 0 0.0
.bss 73532 73532 0 0.0
.data 3372 3372 0 0.0
.rodata 77411 77411 0 0.0
.text 556204 556204 0 0.0
lock-ftd LP_CC2652R7 (read only) 671487 671495 8 0.0
(read/write) 170048 170040 -8 -0.0
.bss 71316 71316 0 0.0
.data 3296 3296 0 0.0
.rodata 76263 76263 0 0.0
.text 594744 594752 8 0.0
lock-mtd LP_CC2652R7 (read only) 653595 653595 0 0.0
(read/write) 183628 183628 0 0.0
.bss 67004 67004 0 0.0
.data 3296 3296 0 0.0
.rodata 100875 100875 0 0.0
.text 552240 552240 0 0.0
pump-app LP_CC2652R7 (read only) 680799 680799 0 0.0
(read/write) 161568 161568 0 0.0
.bss 71380 71380 0 0.0
.data 3296 3296 0 0.0
.rodata 88863 88863 0 0.0
.text 591452 591452 0 0.0
pump-controller-app LP_CC2652R7 (read only) 666527 666527 0 0.0
(read/write) 175976 175976 0 0.0
.bss 71516 71516 0 0.0
.data 3292 3292 0 0.0
.rodata 84679 84679 0 0.0
.text 581368 581368 0 0.0
shell LP_CC2652R7 (read only) 661046 661046 0 0.0
(read/write) 185816 185816 0 0.0
.bss 76556 76556 0 0.0
.data 3376 3376 0 0.0
.rodata 85166 85166 0 0.0
.text 575564 575564 0 0.0
esp32 all-clusters-app c3devkit (read only) 1022520 1022524 4 0.0
(read/write) 1486274 1486274 0 0.0
.dram0.bss 70296 70296 0 0.0
.dram0.data 14600 14600 0 0.0
.flash.rodata 215936 215936 0 0.0
.flash.text 1022520 1022524 4 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1076151 1076151 0 0.0
(read/write) 488312 488312 0 0.0
.dram0.bss 75808 75808 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 246364 246364 0 0.0
.flash.text 1070767 1070767 0 0.0
.iram0.text 123267 123267 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2450608 2450672 64 0.0
.bss 214516 214516 0 0.0
.data 5872 5872 0 0.0
.text 1413252 1413316 64 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1172755 1172755 0 0.0
bss 143120 143120 0 0.0
rodata 141828 141828 0 0.0
text 808856 808856 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1152807 1152807 0 0.0
bss 142356 142356 0 0.0
rodata 133360 133360 0 0.0
text 798164 798164 0 0.0

@woody-apple woody-apple merged commit 8ee4bee into master Jul 28, 2022
@woody-apple woody-apple deleted the tvapps-android17 branch July 28, 2022 20:02
github-actions bot pushed a commit that referenced this pull request Jul 28, 2022
@chrisdecenzo @web-flow
admin access for certain tv clients (#21282)
ad7797c 
* Draft: admin access for certain tv clients

* cleanup acl print shell command, disable placeholder endpoint
woody-apple added a commit that referenced this pull request Jul 29, 2022
@woody-apple @chrisdecenzo
admin access for certain tv clients (#21282) (#21372)
e623dd1 
* Draft: admin access for certain tv clients

* cleanup acl print shell command, disable placeholder endpoint

Co-authored-by: chrisdecenzo <[email protected]>
isiu-apple pushed a commit to isiu-apple/connectedhomeip that referenced this pull request Sep 16, 2022
@chrisdecenzo @isiu-apple
admin access for certain tv clients (project-chip#21282)
0a2cc11 
* Draft: admin access for certain tv clients

* cleanup acl print shell command, disable placeholder endpoint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lazarkov lazarkov lazarkov approved these changes

@woody-apple woody-apple woody-apple approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@rgoliver rgoliver Awaiting requested review from rgoliver

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
app examples review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chrisdecenzo @lazarkov @woody-apple